rich7420 opened a new pull request, #5800:
URL: https://github.com/apache/datafusion-comet/pull/5800

   ## Which issue does this PR close?
   
   Part of #5076.
   
   ## Rationale for this change
   
   ANSI tests that only match message substrings can pass when Comet throws the 
wrong exception type.
   
   ## What changes are included in this PR?
   
   Check Comet execution and compare Spark exception types, error classes and 
SQLSTATE in nine existing array access, arithmetic and cast tests. Preserve the 
array and cast SQL-context checks.
   
   Integral divide and decimal-to-decimal cast retain their existing checks 
with links to #5072. The stricter assertion reproduced the integral-divide 
exception-type mismatch locally.
   
   ## How are these changes tested?
   
   All 13 selected tests passed locally on Spark 4.1.3 / JDK 21: four array 
tests, eight arithmetic tests and one cast test.
   
   [Fork 
CI](https://github.com/rich7420/datafusion-comet/actions/runs/34323839974) 
completed with 44 successful checks, including the Linux and macOS expressions 
jobs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to