jayzhan211 commented on code in PR #24989:
URL: https://github.com/apache/datafusion/pull/24989#discussion_r3949931383
##########
datafusion/functions-aggregate/src/bit_and_or_xor.rs:
##########
@@ -290,8 +290,8 @@ impl AggregateUDFImpl for BitwiseOperation {
}
}
- fn groups_accumulator_supported(&self, _args: AccumulatorArgs) -> bool {
- true
+ fn groups_accumulator_supported(&self, args: AccumulatorArgs) -> bool {
+ !args.is_distinct
Review Comment:
Should we limit operator to XOR only, since AND and OR are idempotent so
DISTINCT does not change their result and they keep the vectorized path.
Also, do we need to handle null case? This could be a follow-up issue
```suggestion
!(args.is_distinct && self.operation == BitwiseOperationType::Xor)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
