adriangb commented on code in PR #22698:
URL: https://github.com/apache/datafusion/pull/22698#discussion_r3947228663
##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -1338,17 +1391,41 @@ struct FilterExecMetrics {
baseline_metrics: BaselineMetrics,
/// Selectivity of the filter, calculated as output_rows / input_rows
selectivity: RatioMetrics,
+ /// Number of partition streams that adopted an adaptively reordered
+ /// evaluation order for the predicate's conjuncts (at most one per
+ /// stream). Registered only when adaptive conjunct reordering is enabled
+ /// and the predicate is a reorderable conjunction, so the flag-off path's
+ /// metrics are unchanged.
+ adaptive_reorders: Option<Count>,
// Remember to update `docs/source/user-guide/metrics.md` when adding new
metrics,
// or modifying metrics comments
}
impl FilterExecMetrics {
- pub fn new(metrics: &ExecutionPlanMetricsSet, partition: usize) -> Self {
+ pub fn new(
+ metrics: &ExecutionPlanMetricsSet,
+ partition: usize,
+ adaptive: bool,
Review Comment:
Can we make this a `with_adaptive_reorder_metrics` to avoid the constructor
breaking change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
