andygrove commented on PR #4950: URL: https://github.com/apache/datafusion-comet/pull/4950#issuecomment-5560628843
@sunchao @comphead I think the CI question was the main thing holding this up, so I've changed the gating: the new `spark_4_2` job is now gated on `workflow_dispatch` only, so the Spark 4.2 SQL tests run neither on PRs nor on merges to `main`. They are on demand for now (Actions -> CI -> Run workflow). That also relates to @comphead's question above about whether we should stop running CI for 4.1 — I'd rather not add a whole extra Spark SQL matrix to every merge until we've decided which older version to retire in exchange, and enabling 4.2 on PRs can then be its own small PR. For the record, the full 4.2 SQL run was green on this branch before I flipped the gate: all seven shards (catalyst, sql_core-1/2/3, sql_hive-1/2/3) passed at 65d16df. Nothing else in the PR changed, apart from the docs that claimed the SQL tests now run in CI. Could you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
