peterxcli commented on PR #5713: URL: https://github.com/apache/datafusion-comet/pull/5713#issuecomment-5560360936
> I'm not sure of the value of this change, tbh. This changes the API and introduces a new invariant that all the callers must respect where previously the behavior was encapsulated and guaranteed to be correct. What is the motivation? I'm assuming there is no performance benefit from removing some integer math? make sense, I also think auto tracking the row count in arrow writer is safer. reverted changes around the arrow writer, only keep the new test, title and description are rewritten, too. ptal! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
