Xuanwo commented on code in PR #23830:
URL: https://github.com/apache/datafusion/pull/23830#discussion_r3943220573
##########
datafusion/core/tests/sql/joins.rs:
##########
@@ -297,3 +299,412 @@ async fn unparse_cross_join() -> Result<()> {
Ok(())
}
+
+fn register_asof_test_tables(ctx: &SessionContext) -> Result<()> {
Review Comment:
Agreed for the SQL-level cases. I kept the Rust tests that need
multi-partition plans, unbounded inputs, or plan-to-SQL roundtrips. I’ll
consolidate the remaining overlap in a follow-up.
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1007,8 +1009,12 @@ impl LogicalPlanBuilder {
)
}
- /// Apply a left-preserving ASOF join using equality expressions and one
- /// ordered match condition.
+ /// Apply a left-preserving ASOF join using pre-separated equality
+ /// expressions and a structured ordered match condition.
+ ///
+ /// This is a low-level API. Most callers should use
+ /// [`asof_join_on`](Self::asof_join_on), which validates and separates
+ /// ordinary predicate expressions.
pub fn asof_join(
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
