rluvaton opened a new pull request, #24918:
URL: https://github.com/apache/datafusion/pull/24918

   ## Which issue does this PR close?
   
   - Follow-up to #24888, which broke the `cargo test hash collisions` CI job 
on `main`.
   
   ## Rationale for this change
   
   The memory-limit test added in #24888 fails when DataFusion is built with 
the `force_hash_collisions` feature. With that feature every key hashes alike, 
so the hash repartitioning sends all groups to a single final stage, and that 
one table cannot fit the 4 MB limit however well the accumulator releases 
memory. The limit was sized for the real distribution across four final stages, 
and the test's purpose, releasing accumulator memory after emitting all groups, 
is unrelated to hash distribution.
   
   ## What changes are included in this PR?
   
   The test is skipped under `force_hash_collisions`, following the existing 
convention in `physical_optimizer/filter_pushdown.rs`, with a comment 
explaining why.
   
   ## What is the testing strategy for this PR?
   
   `cargo test -p datafusion --features force_hash_collisions --test 
core_integration count_distinct_releases` now runs 0 tests; without the feature 
the test still runs and passes.
   
   ## Are there any user-facing changes?
   
   No.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to