milenkovicm commented on PR #2394: URL: https://github.com/apache/datafusion-ballista/pull/2394#issuecomment-5461146486
Although I do not disagree with this PR I would like to raise a concern I don't think we can compare ballista and datafusion / comet, yet. If we had this rule enabled few years back ballista would probably die off, as there was just not enough interest for reviews. It is great to see renewed interest lately but I believe we still have too few committers for such hard requirement, and as review capacity is still left to be desired approvals from involved contributors are still valuable way to get the code merged (which this PR blocks) This PR is not just a config change, this is a WOW style change and should have been left open for a bit more than 6 minutes. Urgency this has been done left me wondering why. Since we got back somewhat working community I don't recall "merge-than-review" privilege (ab)used, to remove it so promptly, correct me if I'm wrong Please do not get me wrong @andygrove and @avantgardnerio there is nobody happier to see ballista alive again and all of you back. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
