sam-1112 commented on PR #5215: URL: https://github.com/apache/datafusion-comet/pull/5215#issuecomment-5453762176
Thanks for the follow-up. On the null-buffer point: as you found in your earlier review of `4874f48`, collecting into `BooleanArray` leaves `nulls()` as `None` for an all-valid input. Therefore, this rewrite does not introduce the extra validity allocation or affect the downstream null fast path. I’ve now added an explicit `assert!(arr.nulls().is_none())` to `test_rlike_string_array_no_nulls` to preserve that property as a regression check. On the dictionary `Utf8View` path: this is already covered in `test_rlike_dictionary_arrays` by the `Dictionary(Int32, Utf8View)` case with `StringViewArray` values, which exercises `as_any_dictionary()` → `is_match_array(Utf8View)` → `take`. The separate `Dictionary(Int8, Utf8)` case covers non-`Int32` keys, so the two dimensions are independently covered. I’m happy to add an `Int8 + Utf8View` cross-product case as well if you would prefer explicit coverage of that combination. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
