comphead commented on code in PR #5368:
URL: https://github.com/apache/datafusion-comet/pull/5368#discussion_r3883464553
##########
spark/src/test/resources/pyspark/benchmark_pyarrow_udf.py:
##########
@@ -84,6 +84,8 @@ def _build_spark() -> SparkSession:
.config("spark.plugins", "org.apache.spark.CometPlugin")
.config("spark.comet.enabled", "true")
.config("spark.comet.exec.enabled", "true")
+ # Keep Comet's scan and execution rules active with Spark's default
shuffle manager.
+ .config("spark.comet.shuffle.enabled", "false")
Review Comment:
why shuffle enabled false? Earlier we assessed that this mode should be only
for testing mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
