ranflarion commented on PR #24736: URL: https://github.com/apache/datafusion/pull/24736#issuecomment-5456709250
> Thank you @ranflarion for the fix. > > This looks correct. I was wondering if adding and assert or a test help? added a test. the assertion that works is a structural invariant rather than a value check: aggregation_time is accumulated strictly inside the elapsed_compute timer that wraps group_aggregate_batch, so aggregation_time <= elapsed_compute always holds and double counting breaks it. there's no wall-clock threshold so no reason for it to be flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
