geoffreyclaude opened a new pull request, #24755: URL: https://github.com/apache/datafusion/pull/24755
## Which issue does this PR close? - Closes #24460. ## Rationale for this change `RelationPlanner` extensions run before DataFusion's built-in CTE lookup. That ordering is useful, but it leaves a name-based extension unable to tell that a CTE should win over a same-named table. Both plans can be valid, so the mistake is silent: the user asks for the CTE and gets the table instead. Downstream projects have had to rebuild this context themselves. For example, [GlossQL collects CTE names in a pre-pass](https://github.com/glossdb/glossql/blob/785bfbb6ee1d13f15a28c43f06dcdb5d78b243a4/crates/session/src/prepass.rs#L509-L523). Its comment captures the rough edge nicely: because the extension cannot ask DataFusion about the current scope, a CTE declared only inside one subquery may have to be treated as visible everywhere. DataFusion already has the precise, lexical CTE scope while it plans the query. This PR makes that information available to the extension that needs it. ## What changes are included in this PR? - Add `RelationPlannerContext::get_cte(&TableReference)`, with a default `None` implementation so existing custom context implementations remain source-compatible. - Connect DataFusion's concrete relation-planner context to the current `PlannerContext` CTE map. - Preserve table identity: only a bare reference can match a CTE, so a quoted CTE named `"foo.bar"` cannot collide with the qualified table `foo.bar`. - Document the opt-in pattern for name-based planners, including the important distinction that a CTE named `numbers` shadows `numbers`, but not a table-function call such as `numbers(10)`. The lookup remains opt-in. A planner with deliberately reserved names can keep intercepting them exactly as it does today. ## Are these changes tested? Yes. The integration tests cover: - ordinary CTE precedence over a virtual relation; - lexical scope for a CTE inside a nested query; - quoted dotted names versus qualified table references; and - a same-named table-function call with arguments. I also ran `cargo fmt --all`, the required all-target/all-feature Clippy command with warnings denied, and the documentation Prettier check. ## Are there any user-facing changes? This adds a small public API for relation-planner authors. It is source-compatible because the trait method has a default implementation. Existing planners keep their current behavior until they opt into the CTE check; planners that do opt in can preserve normal SQL shadowing without re-parsing the statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
