gene-bordegaray commented on code in PR #24598: URL: https://github.com/apache/datafusion/pull/24598#discussion_r3880804979
########## datafusion/physical-plan/src/repartition/range.rs: ########## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Routers for range partitioning. + +use std::cmp::Ordering; +use std::sync::Arc; + +use arrow::array::*; +use arrow::compute::SortOptions; +use arrow::datatypes::*; +use arrow::row::{OwnedRow, RowConverter, SortField}; +use datafusion_common::{ + DataFusionError, Result, ScalarValue, not_impl_err, validate_range_split_points, +}; +use datafusion_physical_expr::SplitPoint; + +/// A router for assigning rows to range partitions. +#[derive(Debug, Clone)] +pub(crate) struct RangeRouter { + split_points: Vec<SplitPoint>, + sort_options: Vec<SortOptions>, + inner: RangeRouterInner, +} + +#[derive(Debug, Clone)] +enum RangeRouterInner { + /// Specialized fast path for a single primitive column with non-null split points. + Primitive(PrimitiveRangeRouter), + /// Universal fast path using Arrow's RowConverter for arbitrary types and composite keys. + Row(RowConverterRangeRouter), +} + +impl RangeRouter { + /// Constructs the best router for the given sort options and split points. + pub(crate) fn try_new( + sort_options: &[SortOptions], + split_points: &[SplitPoint], + ) -> Result<Self> { + validate_range_split_points(split_points, sort_options)?; + + let data_types: Vec<DataType> = if !split_points.is_empty() { Review Comment: here we infer the data type of the spilt pionts and this gets passed to `try_new()` ########## datafusion/physical-plan/src/repartition/range.rs: ########## @@ -0,0 +1,720 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Routers for range partitioning. + +use std::cmp::Ordering; +use std::sync::Arc; + +use arrow::array::*; +use arrow::compute::SortOptions; +use arrow::datatypes::*; +use arrow::row::{OwnedRow, RowConverter, SortField}; +use datafusion_common::{ + DataFusionError, Result, ScalarValue, not_impl_err, validate_range_split_points, +}; +use datafusion_physical_expr::SplitPoint; + +/// A router for assigning rows to range partitions. +#[derive(Debug, Clone)] +pub(crate) struct RangeRouter { + split_points: Vec<SplitPoint>, + sort_options: Vec<SortOptions>, + inner: RangeRouterInner, +} + +#[derive(Debug, Clone)] +enum RangeRouterInner { + /// Specialized fast path for a single primitive column with non-null split points. + Primitive(PrimitiveRangeRouter), + /// Universal fast path using Arrow's RowConverter for arbitrary types and composite keys. + Row(RowConverterRangeRouter), +} + +impl RangeRouter { + /// Constructs the best router for the given sort options and split points. + pub(crate) fn try_new( + sort_options: &[SortOptions], + split_points: &[SplitPoint], + ) -> Result<Self> { + validate_range_split_points(split_points, sort_options)?; + + let data_types: Vec<DataType> = if !split_points.is_empty() { Review Comment: here we infer the data type of the spilt pionts and this gets passed to `try_new()` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
