github-actions[bot] commented on PR #24692: URL: https://github.com/apache/datafusion/pull/24692#issuecomment-5451662541
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v55.0.0 (current) Built [ 38.928s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.147s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 38.578s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.149s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.795s] 223 checks: 220 pass, 3 fail, 0 warn, 31 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/inherent_method_missing.ron Failed in: PiecewiseMergeJoinExec::try_from_proto, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/joins/piecewise_merge_join/exec.rs:752 StatisticsContext::new_with_registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/statistics.rs:149 StatisticsContext::compute_extended, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/statistics.rs:184 StatisticsContext::new_with_registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/statistics.rs:149 StatisticsContext::compute_extended, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/statistics.rs:184 DisplayableExecutionPlan::set_statistics_registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/display.rs:211 ClosureStatisticsProvider::with_matches, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/operator_statistics/mod.rs:1097 AnalyzeExecBuilder::with_statistics_registry, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/analyze.rs:124 --- failure trait_method_default_impl_removed: pub trait default method impl removed --- Description: A method's default impl in an unsealed trait has been removed, breaking trait implementations that relied on that default ref: https://doc.rust-lang.org/book/ch10-02-traits.html#default-implementations impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_default_impl_removed.ron Failed in: trait method datafusion_physical_plan::operator_statistics::StatisticsProvider::compute_statistics in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/operator_statistics/mod.rs:252 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/trait_method_missing.ron Failed in: method compute_statistics_with_args of trait StatisticsProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/operator_statistics/mod.rs:278 method child_stats_requests of trait StatisticsProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/operator_statistics/mod.rs:306 method matches of trait StatisticsProvider, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a1b8be577b359ded4aa4f97c933b2082e307e214/datafusion/physical-plan/src/operator_statistics/mod.rs:320 Summary semver requires new major version: 3 major and 0 minor checks failed Finished [ 79.967s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
