sunchao commented on code in PR #5521: URL: https://github.com/apache/datafusion-comet/pull/5521#discussion_r3878531161
########## CONTRIBUTING.md: ########## @@ -0,0 +1,5 @@ +# Contributing to Apache DataFusion Comet Review Comment: [P2] Add the ASF header required by preflight Please add the usual ASF HTML comment header before this heading. The existing [CI preflight](https://github.com/apache/datafusion-comet/blob/0de89ac92964aff81fbf39e88d04a93a8cfcedd3/.github/workflows/ci.yml#L71-L72) runs `./mvnw -B -N apache-rat:check`; this new root Markdown file is not exempted by the POM, Git ignores, or RAT 0.16.1's note file rules. RAT allows zero unapproved licenses by default, so the headerless file will fail that check and prevent dependent CI jobs from starting when the workflow is allowed to run. This consequence is established from source, not an observed CI failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
