github-actions[bot] commented on PR #23832: URL: https://github.com/apache/datafusion/pull/23832#issuecomment-5449104089
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v55.0.0 (current) Built [ 58.310s] (current) Parsing datafusion v55.0.0 (current) Parsed [ 0.037s] (current) Building datafusion v55.0.0 (baseline) Built [ 58.058s] (baseline) Parsing datafusion v55.0.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.938s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 119.484s] datafusion Building datafusion-expr v55.0.0 (current) Built [ 28.534s] (current) Parsing datafusion-expr v55.0.0 (current) Parsed [ 0.081s] (current) Building datafusion-expr v55.0.0 (baseline) Built [ 29.479s] (baseline) Parsing datafusion-expr v55.0.0 (baseline) Parsed [ 0.083s] (baseline) Checking datafusion-expr v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.857s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301 variant LogicalPlan:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:301 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 61.171s] datafusion-expr Building datafusion-optimizer v55.0.0 (current) Built [ 27.216s] (current) Parsing datafusion-optimizer v55.0.0 (current) Parsed [ 0.033s] (current) Building datafusion-optimizer v55.0.0 (baseline) Built [ 26.976s] (baseline) Parsing datafusion-optimizer v55.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion-optimizer v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.226s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 55.420s] datafusion-optimizer Building datafusion-physical-plan v55.0.0 (current) Built [ 38.673s] (current) Parsing datafusion-physical-plan v55.0.0 (current) Parsed [ 0.159s] (current) Building datafusion-physical-plan v55.0.0 (baseline) Built [ 38.157s] (baseline) Parsing datafusion-physical-plan v55.0.0 (baseline) Parsed [ 0.160s] (baseline) Checking datafusion-physical-plan v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 1.010s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 79.474s] datafusion-physical-plan Building datafusion-proto v55.0.0 (current) Built [ 54.201s] (current) Parsing datafusion-proto v55.0.0 (current) Parsed [ 0.018s] (current) Building datafusion-proto v55.0.0 (baseline) Built [ 54.424s] (baseline) Parsing datafusion-proto v55.0.0 (baseline) Parsed [ 0.020s] (baseline) Checking datafusion-proto v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.173s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 110.303s] datafusion-proto Building datafusion-proto-models v55.0.0 (current) Built [ 24.990s] (current) Parsing datafusion-proto-models v55.0.0 (current) Parsed [ 0.137s] (current) Building datafusion-proto-models v55.0.0 (baseline) Built [ 24.983s] (baseline) Parsing datafusion-proto-models v55.0.0 (baseline) Parsed [ 0.138s] (baseline) Checking datafusion-proto-models v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 2.670s] 223 checks: 222 pass, 1 fail, 0 warn, 31 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.50.0/src/lints/enum_variant_added.ron Failed in: variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1461 variant PhysicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:1461 variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83 variant LogicalPlanType:AsOfJoin in /home/runner/work/datafusion/datafusion/datafusion/proto-models/src/generated/prost.rs:83 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 54.187s] datafusion-proto-models Building datafusion-sql v55.0.0 (current) Built [ 42.979s] (current) Parsing datafusion-sql v55.0.0 (current) Parsed [ 0.034s] (current) Building datafusion-sql v55.0.0 (baseline) Built [ 42.274s] (baseline) Parsing datafusion-sql v55.0.0 (baseline) Parsed [ 0.034s] (baseline) Checking datafusion-sql v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.368s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 86.801s] datafusion-sql Building datafusion-substrait v55.0.0 (current) Built [ 305.027s] (current) Parsing datafusion-substrait v55.0.0 (current) Parsed [ 0.020s] (current) Building datafusion-substrait v55.0.0 (baseline) Built [ 307.346s] (baseline) Parsing datafusion-substrait v55.0.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-substrait v55.0.0 -> v55.0.0 (no change; assume patch) Checked [ 0.312s] 223 checks: 223 pass, 31 skip Summary no semver update required Finished [ 614.595s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
