kosiew commented on code in PR #24539:
URL: https://github.com/apache/datafusion/pull/24539#discussion_r3878266728
##########
datafusion/core/tests/fuzz_cases/scalar_value_fuzz.rs:
##########
@@ -63,6 +67,40 @@ fn scalar_value_iter_to_array_roundtrip() {
});
}
+#[test]
+fn scalar_value_iter_to_array_rejects_mixed_parameterized_types() {
Review Comment:
Could we also add a small deterministic unit test in `datafusion/common`
with one mismatch for each parameter family? The fuzz coverage is useful, but
since it is randomized and gated behind `extended_tests`, having a few fixed
cases would make this regression continuously reproducible and keep the
expected `iter_to_array` behavior documented close to the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
