sunchao commented on PR #5472: URL: https://github.com/apache/datafusion-comet/pull/5472#issuecomment-5447158670
Fixed the normalized-membership fallback issue in [9dd5c044c](https://github.com/apache/datafusion-comet/pull/5472/commits/9dd5c044cf6e427c04a71ad18d6a8554eb14fced). The serializer now retains its normalized operands and copies failure reasons back to the original membership expression. Disabling `Literal` or `KnownFloatingPointNormalized` preserves the specific EXPLAIN reason and works with the test-only strict fallback check enabled. Successful native serialization and admission are unchanged. The full Spark 4.1.3 JVM reactor passed all 37 selected tests (33 planner and four native expression tests), using a freshly built and verified native library. The four new tests cover 72 combinations; each fails when the previous membership serializer is restored. Spotless and the exact CI syntactic Scalafix check also pass. I updated the PR description with the scope and validation; CI for this new commit is pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
