Amogh-2404 commented on PR #24668: URL: https://github.com/apache/datafusion/pull/24668#issuecomment-5420632522
One correction from the final audit: signed `Int8`, `Int16`, `Int32`, and `Int64` negation wraps in the array path. My earlier claim that integer double negation should overflow was wrong; `-(-MIN)` must return `MIN`. The actual problem was a scalar/array inconsistency. Scalar negation was checked, while arrays wrapped. Singleton Parquet statistics and partition values can replace columns with scalars, so the same SQL could either return a value or fail depending on scan metadata. Head `00b519c3a` makes signed integer scalar negation match the existing array semantics. Generic double-negation folding remains removed because checked types, including timestamps, can overflow. The new coverage includes all four integer widths, singleton statistics, derived minimum values, predicates, partition substitution, and AND/OR/XOR. I have corrected the issue and PR descriptions. Full local checks and the pre-push gate pass; fresh CI is running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
