kosiew commented on code in PR #24636:
URL: https://github.com/apache/datafusion/pull/24636#discussion_r3859207637
##########
datafusion/functions/src/datetime/to_timestamp.rs:
##########
@@ -1152,6 +1156,55 @@ mod tests {
Ok(())
Review Comment:
Nice regression test. One small suggestion: could we also add a non-UTC
`Utf8View` array case here? `handle` has a separate `Utf8View` dispatch branch,
so covering it directly would help make sure all string-array paths preserve
the same declared and produced timestamp type. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
