sunchao commented on PR #5159: URL: https://github.com/apache/datafusion-comet/pull/5159#issuecomment-5384315189
Linking the upstream fix mentioned in the follow-ups: [apache/datafusion#24029](https://github.com/apache/datafusion/pull/24029), merged on August 12, fixes [apache/datafusion#24022](https://github.com/apache/datafusion/issues/24022). It makes the list constructors honor the requested `data_type` for non-empty input, addressing the nested-nullability mismatch described here. The current head (`dabc891aa426fa4e8767b547ee8de723c9363055`) still pins DataFusion `54.1.0`, which does not include that fix. Once Comet upgrades to a version containing it, we should rerun `test_collect_agg_absorbs_nested_nullability_drift` and reassess whether this additional normalization is still needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
