4ktLuffy commented on PR #5329:
URL:
https://github.com/apache/datafusion-comet/pull/5329#issuecomment-5380399013
Both addressed — registered in both workflow matrices (check-suites.py now
exits 0),
and the exemption is derived from the live config rather than listed:
private def divergenceExcusable(expr: String): Boolean =
CometConf.isExprAllowIncompat(expr)
Reproduced your experiment: with the static set, an injected mismatch on
RLike
records EXCUSED (suite green) while the same mismatch on EqualTo gives
FAIL-VALUE.
With the derived predicate, RLike gives FAIL-VALUE. All six exempted names
returned
allowIncompatible=false under this suite's config, so RLike wasn't the only
stale one.
Deriving does leave the EXCUSED branch unreachable here, since nothing in
this suite
sets allowIncompatible — happy to delete it instead if you'd rather not
carry dead code.
Rebased on latest main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
