Dandandan commented on PR #2316: URL: https://github.com/apache/datafusion-ballista/pull/2316#issuecomment-5375501418
> Nice work! > > I originally tried to encode to a single file when implementing MPTs, but it ran much slower because I had encoding on the serial path. This PR keeps the encoding parallel, regardless of spill, and that's a big win (see perf numbers below). > > I gave it a thorough review, and the only nit is that it would be worth revisiting the metrics at some point, but that doesn't have to be in this PR. Thanks for the review! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
