lyne7-sc commented on code in PR #24444:
URL: https://github.com/apache/datafusion/pull/24444#discussion_r3813470176
##########
datafusion/physical-plan/src/aggregates/aggregate_hash_table/common.rs:
##########
@@ -544,36 +552,26 @@ impl HashAggregateAccumulator {
))
}
- /// Evaluate aggregate arguments and filter for one input batch.
- ///
- /// For example, `AVG(x + 1) FILTER (WHERE x > 0)` evaluates both `x + 1`
- /// and `x > 0`.
- ///
- /// These arrays can be passed directly to [`GroupsAccumulator`] next.
- pub(super) fn evaluate_acc_args(
Review Comment:
Thanks for the clarification! since we can leave the legacy path unchanged,
the implementation here becomes much simpler. I've updated it accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
