sam-1112 commented on code in PR #5359:
URL: https://github.com/apache/datafusion-comet/pull/5359#discussion_r3791854906
##########
native/spark-expr/src/comet_scalar_funcs.rs:
##########
@@ -260,6 +260,13 @@ pub fn create_comet_physical_fun_with_eval_mode(
let func = Arc::new(crate::string_funcs::spark_levenshtein);
make_comet_scalar_udf!("levenshtein", func, without data_type)
}
+ // Registry UDFs (including datafusion-spark) cannot receive
fail_on_error.
+ _ if fail_on_error => Err(DataFusionError::Execution(format!(
Review Comment:
Fixed. I added an explicit `"make_time" `match arm before the registry
fail-closed branch. `SparkMakeTime` already implements always-throw semantics,
so the arm accepts `fail_on_error=true` without taking the flag as a
constructor argument.
I also added regression coverage for `create_comet_physical_fun("make_time",
..., Some(true))`. Verified with `cargo test -p datafusion-comet-spark-expr
--test test_udf_registration`; all 5 tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
