shinzoxD commented on issue #24230: URL: https://github.com/apache/datafusion/issues/24230#issuecomment-5304946162
Opened #24407 for the remaining `FileSpillWriter::write_all` error path on `main`. The quota-exceeded path already rolls `used_disk_space` back (covered by `test_rollback_on_limit_exceeded_then_drop_returns_to_zero`). An OS write failure after the reservation did not, so `Drop` subtracted only the last successful file size and the leaked bytes permanently shrank spill capacity. The PR releases the reservation on I/O error and adds a regression test that forces the write to fail through a read-only handle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
