andygrove commented on PR #5293:
URL:
https://github.com/apache/datafusion-comet/pull/5293#issuecomment-5302944257
@peterxcli on the rename question - I looked at whether this is achievable
and it isn't, for two reasons.
Git doesn't record renames in commits. It stores trees, and rename detection
is a diff-time heuristic run over file content. Doing `git mv` first and
editing afterwards produces a byte-identical tree and therefore a
byte-identical diff, so it wouldn't change what GitHub renders.
The content is also well under the threshold you mention. Measured
similarity index:
```
$ git diff -M05% --summary main...comet-write-files-seam --
spark/src/main/scala
rename .../serde/operator/{CometDataWritingCommand.scala =>
CometWriteFiles.scala} (27%)
rename .../sql/comet/{CometNativeWriteExec.scala =>
CometWriteFilesExec.scala} (14%)
```
27% and 14%, against git's 50% default. The exec file in particular is a
rewrite rather than a move: the old one owned the commit protocol, the SaveMode
logic and `commitJob`, and the new one only does the per-task write.
What does work is lowering the threshold locally, which pairs both files and
gives the side-by-side view you're after:
```
git diff -M10% main...comet-write-files-seam -- spark/src/main/scala
```
Your proto suggestion is applied in 551c604d8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
