ntjohnson1 commented on code in PR #1678:
URL:
https://github.com/apache/datafusion-python/pull/1678#discussion_r3786211112
##########
crates/core/src/codec.rs:
##########
@@ -443,22 +568,31 @@ fn refuse_inline_payload(kind: &str, name: &str) ->
datafusion::error::DataFusio
/// would round-trip at the logical level but break at the physical
/// level. Both layers reuse the shared payload framing
/// ([`PY_SCALAR_UDF_FAMILY`] et al.) so the wire format is identical.
-#[derive(Debug)]
+#[derive(Debug, Clone)]
pub struct PythonPhysicalCodec {
- inner: Arc<dyn PhysicalExtensionCodec>,
+ chain: Vec<Arc<dyn PhysicalExtensionCodec>>,
python_udf_inlining: bool,
}
impl PythonPhysicalCodec {
pub fn new(inner: Arc<dyn PhysicalExtensionCodec>) -> Self {
Self {
- inner,
+ chain: vec![inner],
python_udf_inlining: true,
}
}
- pub fn inner(&self) -> &Arc<dyn PhysicalExtensionCodec> {
Review Comment:
Similar note about directly referencing codec chain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
