alamb commented on code in PR #24366:
URL: https://github.com/apache/datafusion/pull/24366#discussion_r3785541106


##########
datafusion/common/src/metadata.rs:
##########
@@ -179,10 +173,7 @@ pub fn format_type_and_metadata(
 pub struct FieldMetadata {
     /// The inner metadata of a literal expression, which is a map of string
     /// keys to string values.
-    ///
-    /// Note this is not a `HashMap` because `HashMap` does not provide
-    /// implementations for traits like `Debug` and `Hash`.
-    inner: Arc<BTreeMap<String, String>>,
+    inner: Metadata,

Review Comment:
   Changed the inner field to be `Metadata` (as it is now the same 
representation after https://github.com/apache/arrow-rs/pull/10075)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to