neilconway commented on code in PR #23800: URL: https://github.com/apache/datafusion/pull/23800#discussion_r3785458751
########## datafusion/physical-optimizer/src/limit_pushdown.rs: ########## Review Comment: This is true of the operators in the tree but I don't think it's true in general. Suppose there's a custom operator with n children, a single output partition, and `supports_limit_pushdown() == true`: at that node the materialization branch doesn't fire (one partition) and the blocker branch doesn't run (pushdown supported), so the helper returns with `pending == Some(LimitScope::Global)` still open, and pushdown_limits clones that open requirement into all of its children. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
