alamb commented on PR #24370: URL: https://github.com/apache/datafusion/pull/24370#issuecomment-5294924792
I had codex run some tests on a gcp machine and this PR doesn't improve compialtion speed Details below: Compared PR head d868efbb8e against its base 571477c4a7, using 5 interleaved rounds. A full `cargo clean` and warm build were performed for each checkout; affected package artifacts were cleaned before each timed round. | Crate | Main times (s) | PR times (s) | Main mean (s) | PR mean (s) | |---|---:|---:|---:|---:| | `datafusion-session` | 36.56, 1.44, 1.44, 1.43, 1.46 | 36.35, 1.46, 1.46, 1.46, 1.46 | 8.466 | 8.438 | | `datafusion-catalog` | 36.49, 3.47, 3.48, 3.58, 3.47 | 36.53, 3.50, 3.51, 3.59, 3.52 | 10.098 | 10.130 | | `datafusion` | 14.51, 14.43, 14.46, 14.41, 14.45 | 14.56, 14.50, 14.44, 14.44, 14.49 | 14.452 | 14.486 | The first session/catalog measurements are cold-build outliers. Excluding round 1, the PR was approximately 1.2% slower for session, 0.9% slower for catalog, and 0.2% slower for core—within normal timing noise on this machine. <details> <summary>Exact benchmark commands</summary> ```bash # once per checkout cargo clean cargo build -p datafusion --quiet # each round, before the timed commands cargo clean -p datafusion-session -p datafusion-catalog -p datafusion --quiet # timed commands /usr/bin/time -f "RESULT package=datafusion-session seconds=%e" cargo rustc -p datafusion-session --lib --quiet /usr/bin/time -f "RESULT package=datafusion-catalog seconds=%e" cargo rustc -p datafusion-catalog --lib --quiet /usr/bin/time -f "RESULT package=datafusion seconds=%e" cargo rustc -p datafusion --lib --quiet ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
