floze-the-genius opened a new pull request, #2297: URL: https://github.com/apache/datafusion-ballista/pull/2297
# Which issue does this PR close? Closes #2296. # Rationale for this change Physical-plan snapshots are useful outside the scheduler AQE module. Keeping the helper in that module forces unrelated tests to depend on a scheduler-local test macro and leaves some literal plan checks using ad hoc string equality. # What changes are included in this PR? - Move `assert_plan!` to `ballista-core` so Ballista crates can share one physical-plan snapshot helper. - Update existing scheduler tests to import the macro from `ballista_core`. - Convert the remaining literal physical-plan equality checks in `planner.rs` to inline snapshots. - Leave semantic substring checks and dynamic before/after plan comparisons unchanged. # Are there any user-facing changes? No. This only standardizes test assertions. # Testing - `cargo fmt --all -- --check` - `git diff --check` - The targeted scheduler test profile compiled successfully locally. Test execution was not completed because the local APFS volume ran out of space during post-link stripping; CI is the full test authority for this run. AI assistance: OpenAI Codex was used to help implement and test this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
