zhuqi-lucas commented on PR #24354: URL: https://github.com/apache/datafusion/pull/24354#issuecomment-5290239428
@adriangb on the structural fix — agreed, `remaining_row_groups()` / `retain_row_groups` folds `rg_plan`, `RgPlanEntry`, `sync`, `advance` and the pop into the decoder and kills the whole drift class at once. It also lines up with #24355 (slicing the selection and the row groups together). I would rather land this bug fix as-is and do the restructure as a dedicated follow-up. Thanks for the thorough review + the mutants check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
