dentiny commented on PR #24351: URL: https://github.com/apache/datafusion/pull/24351#issuecomment-5288988666
Thanks, you're right that Cargo Machete already runs in CI. I rechecked the result: Machete does not flag these dependencies because they are referenced through compatibility re-exports (`TableFunction` and `FunctionRegistry`) or enabled through a Cargo feature (`crypto_expressions`), so the existing CI check is behaving as designed rather than missing syntactically unused dependencies. My original PR description incorrectly attributed the findings to Machete. I've updated the title and description to explain the actual analysis and the measured production graph reduction (279 to 257 packages); I don't think changing the Machete CI invocation would detect this class of dependency without adding a separate, likely brittle graph/feature policy check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
