comphead commented on code in PR #24336: URL: https://github.com/apache/datafusion/pull/24336#discussion_r3778341882
########## datafusion/sqllogictest/test_files/pwmj.slt: ########## @@ -342,5 +342,22 @@ ORDER BY 1,2; 1 3 2 3 +# RIGHT JOIN: every right row must be emitted, including one whose join key is +# NULL. A NULL key never matches (NullEqualsNothing), so t2.id = NULL is +# unmatched and must appear as (NULL, NULL). Regression test: the streamed-side +# NULL rows are skipped by the match scan and were previously dropped instead of +# being reported as unmatched. +query II +SELECT t1.id AS left_id, t2.id AS right_id Review Comment: is FULL join is supposed to be tested as well? ########## datafusion/sqllogictest/test_files/pwmj.slt: ########## @@ -342,5 +342,22 @@ ORDER BY 1,2; 1 3 2 3 +# RIGHT JOIN: every right row must be emitted, including one whose join key is +# NULL. A NULL key never matches (NullEqualsNothing), so t2.id = NULL is +# unmatched and must appear as (NULL, NULL). Regression test: the streamed-side +# NULL rows are skipped by the match scan and were previously dropped instead of +# being reported as unmatched. +query II +SELECT t1.id AS left_id, t2.id AS right_id Review Comment: is FULL join supposed to be tested as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
