github-actions[bot] commented on PR #24231: URL: https://github.com/apache/datafusion/pull/24231#issuecomment-5253781844
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 105.338s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.035s] (current) Building datafusion v54.1.0 (baseline) Built [ 107.889s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.036s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.578s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 215.572s] datafusion Building datafusion-physical-optimizer v54.1.0 (current) Built [ 42.348s] (current) Parsing datafusion-physical-optimizer v54.1.0 (current) Parsed [ 0.022s] (current) Building datafusion-physical-optimizer v54.1.0 (baseline) Built [ 40.849s] (baseline) Parsing datafusion-physical-optimizer v54.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-physical-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.115s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure auto_trait_impl_removed: auto trait no longer implemented --- Description: A public type has stopped implementing one or more auto traits. This can break downstream code that depends on the traits being implemented. ref: https://doc.rust-lang.org/reference/special-types-and-traits.html#auto-traits impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/auto_trait_impl_removed.ron Failed in: type GlobalRequirements is no longer UnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-optimizer/src/limit_pushdown.rs:96 type GlobalRequirements is no longer RefUnwindSafe, in /home/runner/work/datafusion/datafusion/datafusion/physical-optimizer/src/limit_pushdown.rs:96 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 84.980s] datafusion-physical-optimizer ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
