Rich-T-kid commented on code in PR #24224:
URL: https://github.com/apache/datafusion/pull/24224#discussion_r3751510232
##########
datafusion/proto-models/proto/datafusion.proto:
##########
@@ -1289,8 +1289,20 @@ message AvroScanExecNode {
FileScanExecConf base_conf = 1;
}
+// Identifies which Arrow IPC format an ArrowScanExecNode reads.
+enum ArrowIpcFormat {
+ // Unset in payloads encoded before this field existed; decoded as the
+ // IPC file format for backward compatibility.
+ ARROW_IPC_FORMAT_UNSPECIFIED = 0;
+ // Arrow IPC file format (with footer, supports range-based parallel reading)
+ ARROW_IPC_FORMAT_FILE = 1;
+ // Arrow IPC stream format (without footer, sequential reading only)
+ ARROW_IPC_FORMAT_STREAM = 2;
+}
Review Comment:
if `ARROW_IPC_FORMAT_UNSPECIFIED` exist for the sake of backwards
compatiability cant the default value be set to `ARROW_IPC_FORMAT_FILE`. this
way we dont need a third variant especially since it will be interpreted as
`ARROW_IPC_FORMAT_FILE` anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
