martin-g commented on code in PR #2258:
URL:
https://github.com/apache/datafusion-ballista/pull/2258#discussion_r3747607365
##########
ballista-cli/src/tui/ui/main/jobs/mod.rs:
##########
@@ -359,14 +360,14 @@ fn render_jobs_table(
}
fn render_job_start_time_cell<'a>(job: &'a Job, app: &App) -> Cell<'a> {
- let start_time = app.format_datetime(job.start_time);
+ let start_time = app.format_datetime(job.start_time as i64);
Review Comment:
```suggestion
let start_time = i64::try_from(job.start_time)
.map_or_else(|_| INVALID_DATE.to_string(), |time|
app.format_datetime(time));
```
##########
ballista-cli/Cargo.toml:
##########
@@ -34,6 +34,7 @@ crate-type = ["cdylib", "rlib"]
[dependencies]
# CLI-only deps (DataFusion/Ballista) — gated by `cli` feature
ballista = { path = "../ballista/client", version = "54.0.0", features =
["standalone"], optional = true }
+ballista-api-types = { path = "../ballista/api-types", version = "54.0.0",
optional = true }
Review Comment:
```suggestion
```
##########
ballista-cli/Cargo.toml:
##########
Review Comment:
```suggestion
# TUI/web shared deps
ballista-api-types = { path = "../ballista/api-types", version = "54.0.0",
optional = true }
```
The dependency is used only by TUI/Web, not by the CLI.
Maybe it should be declared in the workspace Cargo.toml, for easier
management with the rest of the Ballista crates ?!
##########
ballista-cli/src/tui/ui/main/jobs/stage_tasks_popup.rs:
##########
@@ -106,7 +106,7 @@ fn build_stage_task_row(i: usize, task: &StageTaskResponse,
app: &App) -> Row<'s
StageTaskStatus::Successful => {
Text::from("Successful").style(app.theme.status_completed)
}
- StageTaskStatus::Failed { reason } => {
+ StageTaskStatus::Failed { reason, .. } => {
Review Comment:
Do we want to show the `error` too/instead ? Or it may contain sensitive
information ?
The `reason` is just the category.
https://github.com/apache/datafusion-ballista/blob/f485adb91781be1d357bfae1d1796fa8c6842c14/ballista/api-types/src/dto.rs#L66-L71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
