goutamadwant commented on code in PR #24129:
URL: https://github.com/apache/datafusion/pull/24129#discussion_r3733022400
##########
datafusion/pruning/src/pruning_predicate.rs:
##########
@@ -483,13 +480,56 @@ impl<'a> PruningPredicateBuilder<'a> {
/// Build a [`PruningPredicate`], returning the construction error
/// directly. Callers that want the always-true predicate elided or
/// errors folded into a counter should use [`Self::build`] instead.
- pub fn try_build(self, predicate: Arc<dyn PhysicalExpr>) ->
Result<PruningPredicate> {
+ pub fn try_build(
+ self,
+ mut predicate: Arc<dyn PhysicalExpr>,
Review Comment:
right. I left this unchanged for now. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
