akshaychitneni commented on code in PR #2240:
URL:
https://github.com/apache/datafusion-ballista/pull/2240#discussion_r3732320008
##########
ballista/scheduler/src/state/mod.rs:
##########
@@ -309,7 +315,9 @@ impl<T: 'static + AsLogicalPlan, U: 'static +
AsExecutionPlan> SchedulerState<T,
// It's OK to remove executor aggressively,
// since if the executor is in healthy state, it
will be registered again.
- state.remove_executor(&executor_id,
Some(err_msg)).await;
+ state
Review Comment:
I see we let the healthy executor register back and the default
`executor_heartbeat_interval_seconds` is 60s. As with this change, the removal
of executor can trigger `no_executors_grace_period_seconds` which default 30s,
I think we should enforce `no_executors_grace_period_seconds` >
`executor_heartbeat_interval_seconds`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
