mbutrovich commented on issue #5256: URL: https://github.com/apache/datafusion-comet/issues/5256#issuecomment-5181051182
Items 1-2 (`content()`, `specId()`): agree these are latent given the `javap` verification across 1.5.2/1.8.1/1.11.0. Worth noting `CometScanRule` has no analog call for either method either, so even if a future Iceberg release did break `getMethod` here, there's no planning-time path that would catch it first. If reachability ever changes, it lands directly at serde with the plan already committed. Item 3 (`equalityFieldIds`): the assumption that a planning-time reflection failure would already have triggered a fallback does not hold here. `CometScanRule.scala:743-744` calls the same helper on the same object, but its blanket `case _: Exception` treats a genuine invoke failure the same as "no equality ids" and does not add a fallback reason (detail in the #5258 comment). Fixing #5258 is a prerequisite for this one to actually explode loudly at serde instead of silently defaulting at both call sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
