peterxcli commented on code in PR #5044:
URL: https://github.com/apache/datafusion-comet/pull/5044#discussion_r3691721413
##########
native/spark-expr/src/math_funcs/wide_decimal_binary_expr.rs:
##########
@@ -281,7 +281,13 @@ impl PhysicalExpr for WideDecimalBinaryExpr {
}
};
- let result = if eval_mode != EvalMode::Ansi {
+ let result = if eval_mode != EvalMode::Ansi &&
result.values().contains(&i128::MAX) {
Review Comment:
yes, capture the overflow in `check_overflow_and_convert` makes more sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
