0lai0 commented on issue #23929: URL: https://github.com/apache/datafusion/issues/23929#issuecomment-5143392167
Sounds great, one-issue-per-expression with the epic linking them works well. On the "used outside Spark" point: the decimal overflow case in apache/datafusion-comet#5022 is a concrete example. Per that issue's description, the overflow Err originates in core ScalarValue arithmetic rather than a datafusion-spark expression, so it's a case where the caveat applies. Not sure if it fits this epic's scope, but flagging it. Let me know if it's worth a linked issue. One more thing: some ANSI work is cross-cutting (the session ansi flag plumbing, a shared overflow helper) rather than per-expression. Would a shared infra issue help, so each expression issue can build on it instead of redoing it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
