kosiew commented on code in PR #23857: URL: https://github.com/apache/datafusion/pull/23857#discussion_r3664469087
########## datafusion/sqllogictest/test_files/metadata.slt: ########## @@ -520,3 +520,11 @@ NULL the id field statement ok drop table table_with_metadata; + +# Test that swapped cross-join preserves metadata on conflicting values on metadata. Review Comment: Nice regression test! One small thing I noticed is that the setup attaches the conflicting `metadata_key` to the Arrow `Schema`, but this comment says the fields have conflicting metadata. The query also only verifies the returned values. Would it make sense to either update the comment to explain that this is a planner/runtime regression where conflicting schema metadata should not cause a swapped cross join to fail, or add an assertion with `arrow_metadata(...)` if preserving field metadata is the behaviour you want to verify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
