peterxcli commented on code in PR #23854:
URL: https://github.com/apache/datafusion/pull/23854#discussion_r3647644589
##########
datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs:
##########
@@ -398,6 +404,15 @@ impl SharedBuildAccumulator {
),
};
+ let probe_range_partitioning = if partition_mode ==
PartitionMode::Partitioned {
+ match right_child.output_partitioning() {
+ crate::Partitioning::Range(range) => Some(range.clone()),
+ _ => None,
+ }
+ } else {
+ None
+ };
+
Review Comment:
done. this suggestion is really great and makes the code cleaner, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
