Rich-T-kid commented on code in PR #23344:
URL: https://github.com/apache/datafusion/pull/23344#discussion_r3646305944
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -215,6 +215,11 @@ pub struct GroupValuesColumn<const STREAMING: bool> {
/// [`GroupValuesRows`]: crate::aggregates::group_values::GroupValuesRows
group_values: Vec<Box<dyn GroupColumn>>,
+ /// Indices into `group_values` ordered cheapest to most expensive
comparison
+ /// cost. Built once in `try_new` from the schema so that
`vectorized_equal_to`
+ /// eliminates rows with cheap columns before paying the cost of expensive
ones.
+ compare_order: Vec<usize>,
Review Comment:
Good find, updating it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
