andygrove opened a new issue, #5007: URL: https://github.com/apache/datafusion-comet/issues/5007
### Describe the bug Adding a non-gating label to a PR (e.g. the `performance` label that is auto-applied to `perf:` PRs shortly after they open) spawns a second, entirely-skipped `CI` workflow run. That run's Preflight `if:` guard is designed to skip for any label other than `run-spark-3.4-tests` / `run-spark-4.0-tests` / `run-spark-4.1-tests` / `run-iceberg-tests`, so Preflight → `changes` → every top-level heavy job all report `skipped`. Because the skipped top-level jobs (`Spark SQL Tests (Spark 3.5)`, `PR Build (Linux)`, `Preflight`, etc.) are emitted as bare-named check-runs, and the real opened/synchronize run surfaces its equivalent work only under child job names (e.g. `PR Build (Linux) / Spark 3.5, JDK 17, Scala 2.13 [exec]`), the merge-box summary displays the phantom run's skipped checks as the status for those names. The result is a misleading "All checks have passed / N skipped" summary even while the real run is still executing the actual tests. Example: PR #5006. Two check suites on the same head commit: - `81355095172` (opened/synchronize): Preflight **success**, all heavy jobs running. - `81355386892` (`labeled`, `performance`): Preflight **skipped**, all 14 top-level jobs skipped. ### Steps to reproduce 1. Open a PR whose title starts with `perf:` (so the `performance` label is auto-added), or manually add any non-gating label right after opening a PR. 2. Observe two `CI` workflow runs for the same commit. 3. The `labeled`-event run skips Preflight and all downstream jobs. 4. The PR merge-box shows those top-level CI job names as `Skipped`, shadowing the real run. ### Expected behavior A non-gating label should not create a phantom, fully-skipped CI run whose skipped check-runs shadow the real run in the merge box. Either: - gate the workflow so non-gating `labeled` events never start a `CI` run at all (rather than starting it and skipping inside Preflight), or - otherwise avoid emitting the bare-named skipped top-level check-runs that override the real run's status. ### Additional context Relevant config is the Preflight `if:` guard and `concurrency` group in `.github/workflows/ci.yml`. The `concurrency` comment already anticipates label races and keys labeled runs into their own subgroup so they don't cancel the commit run; the remaining issue is that the labeled run still publishes skipped check-runs under the shared job names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
