github-actions[bot] commented on PR #23842: URL: https://github.com/apache/datafusion/pull/23842#issuecomment-5060064994
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 109.511s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v54.1.0 (baseline) Built [ 106.649s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.879s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_missing.ron Failed in: trait datafusion::physical_planner::PhysicalPlanner, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/core/src/physical_planner.rs:126 trait datafusion::execution::context::QueryPlanner, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/core/src/execution/context/mod.rs:2192 trait datafusion::physical_planner::ExtensionPlanner, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/core/src/physical_planner.rs:158 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 218.659s] datafusion Building datafusion-ffi v54.1.0 (current) Built [ 60.114s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.064s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 59.231s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.317s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 121.015s] datafusion-ffi Building datafusion-physical-optimizer v54.1.0 (current) Built [ 38.951s] (current) Parsing datafusion-physical-optimizer v54.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-optimizer v54.1.0 (baseline) Built [ 39.265s] (baseline) Parsing datafusion-physical-optimizer v54.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-physical-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.149s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_missing.ron Failed in: trait datafusion_physical_optimizer::optimizer::PhysicalOptimizerContext, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/physical-optimizer/src/optimizer.rs:53 trait datafusion_physical_optimizer::PhysicalOptimizerContext, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/physical-optimizer/src/optimizer.rs:53 trait datafusion_physical_optimizer::optimizer::PhysicalOptimizerRule, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/physical-optimizer/src/optimizer.rs:95 trait datafusion_physical_optimizer::PhysicalOptimizerRule, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/d3041a510850a1a6a9895a9ed5c88e5373a7ac6e/datafusion/physical-optimizer/src/optimizer.rs:95 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 79.413s] datafusion-physical-optimizer Building datafusion-session v54.1.0 (current) Built [ 35.761s] (current) Parsing datafusion-session v54.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-session v54.1.0 (baseline) Built [ 36.334s] (baseline) Parsing datafusion-session v54.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-session v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.235s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 73.325s] datafusion-session ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
