nuno-faria commented on code in PR #23755: URL: https://github.com/apache/datafusion/pull/23755#discussion_r3625009152
########## datafusion/sqllogictest/test_files/math.slt: ########## @@ -1055,6 +975,38 @@ SELECT lcm(arrow_cast(column1, 'Decimal128(38,0)'), arrow_cast(column2, 'Decimal 18 0 +# lcm with the remaining decimal array widths Review Comment: nit: I think this comment is not needed. We can even order Decimal32 -> Decimal256 just for consistency, but it's not that important. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
