zhuqi-lucas commented on PR #23701:
URL: https://github.com/apache/datafusion/pull/23701#issuecomment-5029983068
Good point on splitting @adriangb — I agree the shape change and the config
gate are logically independent and shouldn't both stack on #22384. Two
clarifications on ordering:
- Standalone, none of the three (membership gate, union bounds, RightSemi
skip) introduces regression against current main — Layer 3 from #22384 isn't in
main yet, so the filter still silent-drops in `pushdown_filters=false` and our
changes are no-ops there.
- The regression window opens only when #22384 lands. So the sequence I'd
propose:
1. Split PR A (membership gate) → merge to main
2. Split PR B (union bounds shape) → merge to main
3. #22384 merges — Layer 3 activates, and both A + B are already in main
to prevent the CASE hash-routed / membership tax.
If your adaptive work (#22234 / #22237) lands before step 3, A + B can be
superseded — but they're cheap enough (~50 lines total) that landing them
independently doesn't block anything.
Happy to split as described. Want me to close this PR and open A + B fresh
against main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
